New keys for tenant branding for 2283 - #128
Open
reshmabidikar wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work for TS#299
CompanyInfo/BrandInfo/LogoInfoto this repo so they can be shared by KB core/email notification plugin and aviate pluginTenantKV(I might move the invoice template/email notification plugin specific keys into their own repos in a separate pass)BrandingLoaderto this repo so it can be shared by KB core/email notification plugin and aviate plugin. Note that this is a slight deviation because so far, this repo mostly has only interfaces, it does not have any business logic. However, theBrandingLoaderclass introduces some business logic in this repo. I could not find any other repo to put this, if you think this should be placed in some other repo, let me know.