Repository navigation
Conversation
Admins couldn't narrow the Request Management table to one kind of request. Add a `type` query param to GET /api/admin/requests (`audiobook` or `ebook`; `all` or an unknown value means no filter) and a Type dropdown between the Status and User filters. Like the other filters, it's kept in the URL (left out for All Types), resets to page 1, counts toward Clear, and follows back/forward. It shows even with the ebook sidecar off, since older ebook requests stay listed.
Owner
|
@NichCodes thanks, this is the filter I was hoping for. I'm bringing it in on a branch of mine with you as co-author, and I'll close this one when it lands. |
kikootwo
added a commit
that referenced
this pull request
Nov 2, 2026
…pping Clear With four filters plus Clear in one non-wrapping row, between 640 and about 710 px wide Clear was cut off by the card and the search box shrank to about 54 px. From 640 px the row now wraps, and the search box keeps at least 240 px. Phone widths still stack, and 1280 px is unchanged. The #519 e2e spec checks Clear sits inside the card and the search box is at least 160 px wide at 680 and 375 px, with screenshots at those widths. Co-authored-by: NichCodes <90598280+NichCodes@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
kikootwo
added a commit
that referenced
this pull request
Nov 2, 2026
Co-authored-by: NichCodes <90598280+NichCodes@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
kikootwo
added a commit
that referenced
this pull request
Nov 2, 2026
…requests (#537) The admin Request Management table gets a Type select (All Types / Audiobooks / Ebooks), backed by GET /api/admin/requests?type=. The API takes only audiobook or ebook; all, missing or any other value applies no type filter. The select works like the status filter: kept in the address (left out for All Types), restored by back and forward, resets to page 1, and counts toward Clear. It shows with the ebook sidecar off, since earlier ebook requests stay listed. From 640 px the filter row wraps instead of shrinking the search box, so Clear is never cut off by the card. Every string filter in the table's API URL is now encoded, so a crafted page address cannot add API parameters. Based on #519 by @NichCodes. Co-authored-by: NichCodes <90598280+NichCodes@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
|
@NichCodes thanks again. It's in now as #537 with you as co-author: Request Management has the Type filter (All Types, Audiobooks, Ebooks), kept in the page address like the status filter. I also let the filter row wrap on narrower windows so the Clear button isn't cut off. It will be in the next release. Closing this one in favour of #537. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This adds a Type dropdown (All Types / Audiobooks / Ebooks) to the Request Management table on the Admin dashboard, backed by a
typequery param onGET /api/admin/requests.Details
type=audiobookortype=ebookfilters byRequest.type.all, a missing value or an unknown value means no filter, so bad input never reaches the query.Testing
tests/api/admin-requests.routes.test.ts: filters foraudiobookandebook, no filter forallor an unknown value.tests/app/admin/components/RecentRequestsTable.test.tsx: the Type dropdown renders; choosing Ebooks sendstype=ebookand goes back to page 1; Clear resets it.tests/app/admin.page.test.tsx: the table's expected request URL now includestype=all.docker compose buildsucceeds.documentation/admin-dashboard.md.