Repository navigation
docs: the size score gives full points from about 140 kbps, not 64 - #493
Merged
Merged
Conversation
…bps, not 64 (#318) 1.0 MB/min with MB in MiB is about 139.8 kbps, so a 64 kbps release scores about 6.9 of the 15 size points. The comment said "~64 kbps". Comments and docs now describe what the code does; scoring is unchanged. A test pins the documented numbers. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #318
What changed
scoreSize()comments (src/lib/utils/ranking-algorithm.ts): the comment said full points at 1.0 MB/min were "~64 kbps".sizeMBis in MiB, so 1.0 MB/min is 1,048,576 × 8 / 60 ≈ 139.8 kbps. The comments now say about 140 kbps and give the points at 128 kbps (13.7), 64 kbps (6.9), 0.5 MB/min (about 70 kbps, 7.5) and 0.3 MB/min (about 42 kbps, 4.5).documentation/phase3/ranking-algorithm.md): the audiobook scoring criteria had no size section. A new "4. Size Quality" section covers the formula, where full points start (about 140 kbps), the points at 128, 64 and 32 kbps, and the size notes. A Fixed Issues entry is added for Size score: the "1.0 MB/min ≈ 64 kbps" baseline is off by about 2x, so 64 kbps releases lose half their size points #318.tests/utils/ranking-size-score.test.tspins those numbers throughgetScoreBreakdown(): 32 kbps 3.43, 64 kbps 6.87, 128 kbps 13.73; 139 kbps under 15, 140 and 320 kbps at 15.main, only comments.Why
The comment and the constant disagreed, as #318 showed with measured releases. The ruling was to make the comment and the docs describe what the code does, and to leave any move of the baseline to the #223 threshold work.
Which case applied: #459 (the #223 work, f5b0543) did not change the size baseline.
scoreSize()is the same onmain(d8011ab) as before #459, anddocumentation/phase3/match-gates.mdlistsscoreSizeamong the parts #459 left unchanged. So this branch changes only docs and comments. Full points still start at about 140 kbps, and a 64 kbps release still gets about 8 of the 15 size points less.Evidence
tests/utils/ranking-size-score.test.ts: 4/4 pass on this branch, and 4/4 withmain'ssrc(d8011ab), since the scoring is the same.tests/utils/ranking-algorithm.test.ts(it includes the existing "full size score for >= 1.0 MB/min" test) and the new file: 104/104 pass.Checks
tsc --noEmitclean). ESLint reports nothing new in the two touched files: one existing warning inranking-algorithm.ts(an unusedtitleparameter at line 416) is the same onmain.Risk and rollback
🤖 Generated with Claude Code