Repository navigation
fix(sabnzbd): recover duplicate NZB downloads with disk files and avoid hard failure auto-blocking - #252
Closed
thehaven wants to merge 1 commit into
Closed
fix(sabnzbd): recover duplicate NZB downloads with disk files and avoid hard failure auto-blocking#252thehaven wants to merge 1 commit into
thehaven wants to merge 1 commit into
Conversation
…id hard failure auto-blocking
Owner
|
First, credit where it's due @thehaven: the problem here is real. SABnzbd reporting "Duplicate NZB" while the files are already sitting on disk shouldn't end in a failed, blocked request. I'm going to close this one though, and I want to explain why so it doesn't feel like a black-box rejection:
Looking the item up directly by its |
Owner
|
Tracking the reimplementation in #329. |
Owner
|
@thehaven this is out in v1.2.12, landed in #480 with you as co-author: https://github.com/kikootwo/ReadMeABook/releases/tag/v1.2.12 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Disclosure: This pull request was developed with assistance from Google Antigravity / Gemini CLI (
gemini-cli) AI coding assistant. All implementation logic and unit tests (vitest100% passing) have been empirically verified in production container deployments.📦 Summary & Problem Solved
Status: Failedwithfail_message: "Duplicate NZB". ReadMeABook previously mapped this directly tofailed, permanently auto-blocking the release name in the database even when SABnzbd had already downloaded the completed files to disk.sabnzbd.service.tsnow inspects thestoragepath on disk whenDuplicate NZBis reported, overriding status tocompletedif files exist sofile-organizerimports them.monitor-download.processor.tsprevents release auto-blocking when SABnzbd reports a duplicate, resetting the request toawaiting_searchto allow alternate search retry.scan-orphaned-downloads.processor.tsto inspect both complete and download folders for un-imported duplicate releases.🧪 Unit Test Verification