import graphql from graphql/index.js#9936
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is for #9929 to work around Vitest loading the ESM in Node.js when it shouldn't do that, I was initially thinking a workaround wouldn't be great since consumers would also have to do some workaround but really this will just be retaining the status quo since consumers doing
"type": "module"in their projects would already require some workaround for this. (I believe"type": "module"for a consumer would be broken at the moment anyway since we emit CJS without a.cjsin.keystone).In
graphql@17, I believe we'll have to revert this since it uses anexportsfield.graphql@17also resolves this anyway so that's a non-issue.