Skip to content

fix: Fail build if curl of cached file fails #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
darcywong00 merged 2 commits into from
Feb 5, 2026
Merged

fix: Fail build if curl of cached file fails #339

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
027daa7
fix: Fail build if curl of cached file fails
darcywong00 Feb 5, 2026
732ccde
Update resources/external.inc.sh
darcywong00 Feb 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions resources/external.inc.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,17 +130,17 @@ retrieve_cached_model() {
case "$extension" in
js)
local js_filename=`curl "$query" | $JQ -r '.[].jsFilename'`
curl -s -L "$js_filename" --output "$path$filename" --create-dirs || die "Unable to download $js_filename"
curl -s -L -f "$js_filename" --output "$path$filename" --create-dirs || builder_die "Unable to download $js_filename"
;;
kmp)
local kmp_filename=`curl "$query" | $JQ -r '.[].packageFilename'`
curl -s -L "$kmp_filename" --output "$path$filename" --create-dirs || die "Unable to download $kmp_filename"
curl -s -L -f "$kmp_filename" --output "$path$filename" --create-dirs || builder_die "Unable to download $kmp_filename"
;;
model_info)
# .model_info is downloaded up a level (not at $path)
local version=`curl "$query" | $JQ -r '.[].version'`
local model_info_filename="https://downloads.keyman.com/models/${model_id}/${version}/${model_id}.model_info"
Comment thread
darcywong00 marked this conversation as resolved.
Outdated
curl -s -L "$model_info_filename" --output "$model_id.model_info" --create-dirs || die "Unable to download $model_info_filename"
curl -s -L -f "$model_info_filename" --output "$filename" --create-dirs || builder_die "Unable to download $model_info_filename"

@darcywong00 darcywong00 Feb 5, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$filename = $model_id.model_info

But keeping consistent with the other files

;;
*)
die "$path $filename had unexpected extension (expecting js, kmp, or model_info)"
Expand Down
Loading