Skip to content

chore(web): adjust types in guide-examples tests #16523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ermshiperete merged 1 commit into from
Sep 7, 2026
+14 −14
Merged

chore(web): adjust types in guide-examples tests #16523

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 14 additions & 14 deletions web/src/test/auto/e2e/guide-examples.tests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ test.describe.skip('First example from the guide', function () {
await setTimeoutAndLoadPage(page, 'http://localhost:3000/build/docs/engine/guide/examples/__first-example.html');
}

test('Input field shows US keyboard', async ({ page }) => {
test('Input field shows US keyboard', async ({ page } : { page: Page }) => {
// Setup
await beforeEach(page);
const oskTitleBar = await clickFieldAndWaitForOSK(page, page.getByPlaceholder('Hello World'));
Expand All @@ -29,7 +29,7 @@ test.describe.skip('First example from the guide', function () {
await expect(await getSelectedKeyboardMenuText(page)).toBe('English - US');
});

test('Keyman menu has expected keyboards', async ({ page }) => {
test('Keyman menu has expected keyboards', async ({ page } : { page: Page }) => {
// Setup
await beforeEach(page);
await clickFieldAndWaitForOSK(page, page.getByPlaceholder('Hello World'));
Expand All @@ -46,7 +46,7 @@ test.describe.skip('Auto-control example from the guide', function () {
await setTimeoutAndLoadPage(page, 'http://localhost:3000/build/docs/engine/guide/examples/__auto-control.html');
}

test('Input field shows Lao keyboard', async ({ page }) => {
test('Input field shows Lao keyboard', async ({ page } : { page: Page }) => {
// Setup
await beforeEach(page);
await page.getByTestId('multilingual' ).click();
Expand All @@ -57,7 +57,7 @@ test.describe.skip('Auto-control example from the guide', function () {
await expect(page.locator('#keymanweb_title_bar')).toContainText('Lao (Phonetic)');
});

test('Textarea shows Lao keyboard', async ({ page }) => {
test('Textarea shows Lao keyboard', async ({ page } : { page: Page }) => {
// Setup
await beforeEach(page);
await page.getByTestId('textarea').click();
Expand All @@ -74,7 +74,7 @@ test.describe.skip('Control-by-control example from the guide', function () {
await setTimeoutAndLoadPage(page, 'http://localhost:3000/build/docs/engine/guide/examples/__control-by-control.html');
}

test('address field does not have KeymanWeb enabled', async ({ page }) => {
test('address field does not have KeymanWeb enabled', async ({ page } : { page: Page }) => {
// Setup
await beforeEach(page);
await page.getByPlaceholder('id = address').click();
Expand All @@ -87,7 +87,7 @@ test.describe.skip('Control-by-control example from the guide', function () {
});

// TODO: #16080
test.skip('subject field does not show keyboard and defaults to system keyboard', async ({ page }) => {
test.skip('subject field does not show keyboard and defaults to system keyboard', async ({ page } : { page: Page }) => {
// Setup
await beforeEach(page);
await page.getByPlaceholder('id = subject').click();
Expand All @@ -101,7 +101,7 @@ test.describe.skip('Control-by-control example from the guide', function () {
await expect(await getSelectedKeyboardMenuText(page)).toBe('(System keyboard)');
});

test('message body field shows Lao keyboard', async ({ page }) => {
test('message body field shows Lao keyboard', async ({ page } : { page: Page }) => {
// Setup
await beforeEach(page);
await page.getByPlaceholder('id = text').click();
Expand All @@ -124,7 +124,7 @@ test.describe.skip('Full manual control example from the guide', function () {
await setTimeoutAndLoadPage(page, 'http://localhost:3000/build/docs/engine/guide/examples/__full-manual-control.html');
}

test('Shows English and no OSK after loading page', async ({ page }) => {
test('Shows English and no OSK after loading page', async ({ page } : { page: Page }) => {
// Setup
await beforeEach(page);

Expand All @@ -134,7 +134,7 @@ test.describe.skip('Full manual control example from the guide', function () {
await expect(await page.evaluate(() => keyman.osk.isVisible())).not.toBeTruthy();
});

test('Selecting English keyboard shows no OSK', async ({ page }) => {
test('Selecting English keyboard shows no OSK', async ({ page } : { page: Page }) => {
// Setup
await beforeEach(page);
// first switch to Hebrew
Expand Down Expand Up @@ -164,7 +164,7 @@ test.describe.skip('Full manual control example from the guide', function () {
await expect(await page.evaluate(() => keyman.osk.isVisible())).not.toBeTruthy();
});

test('Selecting Devanagari keyboard shows Devanagari OSK', async ({ page }) => {
test('Selecting Devanagari keyboard shows Devanagari OSK', async ({ page } : { page: Page }) => {
// Setup
await beforeEach(page);
const keyboardchangePromise = page.evaluate(async () => {
Expand All @@ -183,7 +183,7 @@ test.describe.skip('Full manual control example from the guide', function () {
await expect(page.locator('#keymanweb_title_bar')).toContainText('Devanagari (INSCRIPT)');
});

test('Selecting Hebrew shows Hebrew OSK', async ({ page }) => {
test('Selecting Hebrew shows Hebrew OSK', async ({ page } : { page: Page }) => {
// Setup
await beforeEach(page);
const keyboardchangePromise = page.evaluate(async () => {
Expand All @@ -208,7 +208,7 @@ test.describe.skip('Manual control example from the guide', function () {
await setTimeoutAndLoadPage(page, 'http://localhost:3000/build/docs/engine/guide/examples/__manual-control.html');
}

test('Does not show OSK after loading', async ({ page }) => {
test('Does not show OSK after loading', async ({ page } : { page: Page }) => {
// Setup
await beforeEach(page);
await page.getByTestId('multilingual').click();
Expand All @@ -218,7 +218,7 @@ test.describe.skip('Manual control example from the guide', function () {
await expect(await page.evaluate(() => keyman.osk.isVisible())).not.toBeTruthy();
});

test('Shows Lao OSK after clicking button', async ({ page }) => {
test('Shows Lao OSK after clicking button', async ({ page } : { page: Page }) => {
// Setup
await beforeEach(page);
await page.getByAltText('KeymanWeb').click();
Expand All @@ -230,7 +230,7 @@ test.describe.skip('Manual control example from the guide', function () {
await expect(page.locator('#keymanweb_title_bar')).toContainText('Lao');
});

test('Hides Lao OSK after clicking button', async ({ page }) => {
test('Hides Lao OSK after clicking button', async ({ page } : { page: Page }) => {
// Setup
await beforeEach(page);

Expand Down