feat(mac): add logging to Keyman Configuration app 馃崕 - #16494
Open
sgschantz wants to merge 8 commits into
Open
Conversation
User Test ResultsTest specification and instructions User tests are not required Test Artifacts |
keymanapp-test-bot
Bot
changed the title
also replace references to URL.path with URL.path(percentEncoded: false) because FileManager operation do not expect percent encoding
sgschantz
marked this pull request as ready for review
September 3, 2026 02:30
mcdurdin
approved these changes
Sep 4, 2026
| var fullTaskList = neededTasks | ||
| Logger.app.debug("completeNewInstallationEvaluation: created new installation state") | ||
|
|
||
| var fullTaskList = neededTasks |
| return(nil) | ||
| Logger.setup.error("Could not find the specified input source with bundleID: \(bundleId, privacy: .public)") | ||
| LogUtil.errorBreadcrumb("Could not find the specified input source with bundleID: \(bundleId)", category: .setup) | ||
| return(nil) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace print statements with calls to Apple's unified logging system.
Add support for Sentry and add breadcrumbs to provide context to crash reports.
It would be nice to simplify the code and wrap the calls to Apple's logger and Sentry with some utility functions, but Quinn advises against this: Your Friend the System Log
So, instead, there are many places where there is a call to the Apple log followed by a call to Sentry to queue up a breadcrumb in case a crash happens.
Build-bot: release:mac
Test-bot: skip