Skip to content

fix(android): load KMP files from app-external sources #16392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jahorton wants to merge 7 commits into
base: master
Choose a base branch
from
+28 −72
Open

fix(android): load KMP files from app-external sources #16392

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f4a67d8
fix(android): load KMP files from app-external sources
jahorton Aug 17, 2026
90b2e45
change(web): add vnd.keyman.kmp+zip mime type to file-association int…
jahorton Aug 18, 2026
ba76704
change(android): clean up AndroidManifest.xml MIME-type entries, remo…
jahorton Aug 19, 2026
af0a2b6
change(android): revert autoVerify="true" change
jahorton Aug 25, 2026
507512b
change(android): clean up site deep-link configuration
jahorton Aug 25, 2026
abb2b82
Merge pull request #16438 from keymanapp/change/android/clean-site-de…
jahorton Sep 2, 2026
f0e79e2
docs(android): shift comment text to retrigger build
jahorton Sep 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
93 changes: 27 additions & 66 deletions android/KMAPro/kMAPro/src/main/AndroidManifest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,10 +96,6 @@
<category android:name="android.intent.category.BROWSABLE" />
<category android:name="android.intent.category.DEFAULT" />

<!-- needed for properly formatted email messages -->
<data
android:mimeType="application/vnd.keyman"
android:scheme="content" />
<!-- needed for mangled email messages -->
<data
android:mimeType="application/keyman"
Expand All @@ -109,38 +105,41 @@
android:mimeType="application/octet-stream"
android:scheme="content" />
<data
android:mimeType="application/x-keyman-package"
android:mimeType="application/vnd.keyman.kmp+zip"
android:scheme="content" />
</intent-filter>

<!--
Capture file open requests (pathPattern is honoured) where no
MIME type is provided in the Intent. An Intent with a null
MIME type will never be matched by a filter with a set MIME
type, so we need a second intent-filter if we wish to also
match files with this extension and a non-null MIME type
(even if it is non-null but zero length).
-->
<intent-filter android:priority="50">
<action android:name="android.intent.action.VIEW" />

<category android:name="android.intent.category.BROWSABLE" />
<category android:name="android.intent.category.DEFAULT" />

<data android:scheme="file" />
<data android:scheme="content" />

@mcdurdin mcdurdin Aug 19, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this do?

@jahorton jahorton Aug 19, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Matches both file:/// and content:// URIs. Often times, what we get between apps appears to be the content:// one.

It's an OR, not an AND - allowing us to share the host and pathPattern entries for both protocols.

@mcdurdin mcdurdin Aug 20, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure what this is fixing though -- does this impact the underlying reported issue?

@mcdurdin mcdurdin Sep 5, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still wondering if there is a reported issue that this is addressing?


<data android:host="*" />
<data android:pathPattern="/.*\\.kmp" />
<data android:pathPattern=".*\\.kmp" />
<data
android:mimeType="application/vnd.keyman.kmp+zip"
android:scheme="content" />

@mcdurdin mcdurdin Sep 5, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto


<!--
Backup MIME intents
-->
<data
android:mimeType="application/octet-stream"

@mcdurdin mcdurdin Sep 5, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally we won't need this in the future? It seems a bit broad!

android:scheme="content" />

@mcdurdin mcdurdin Sep 5, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a duplicate of line 119?

</intent-filter>

<!--
Capture file open requests (pathPattern is honoured) where a
(possibly blank) MIME type is provided in the Intent. This
filter may only be necessary for supporting ES File Explorer,
which has the probably buggy behaviour of using an Intent
with a MIME type that is set but zero-length. It's
impossible to match such a type except by using a global
wildcard.
-->
Capture file open requests (pathPattern is honoured) where no
MIME type is provided in the Intent. An Intent with a null
MIME type will never be matched by a filter with a set MIME
type, so we need a second intent-filter if we wish to also
match files with this extension and a non-null MIME type
(even if it is non-null but zero length).
-->
<intent-filter android:priority="50">
<action android:name="android.intent.action.VIEW" />

Expand All @@ -149,25 +148,8 @@

<data android:scheme="file" />
<data android:host="*" />
<data android:mimeType="*/*" />
<data android:pathPattern="/.*\\.kmp" />
</intent-filter>
<intent-filter>
<action android:name="android.intent.action.VIEW" />

<category android:name="android.intent.category.DEFAULT" />
<category android:name="android.intent.category.BROWSABLE" />

<!-- http:// and https:// protocols -->
<data
android:host="*"
android:pathPattern="/.*\\.kmp"
android:scheme="http" />
<data
android:host="*"
android:pathPattern="/.*\\.kmp"
android:scheme="https" />
</intent-filter>

<intent-filter>
<!-- keyman:download// deep linking to https://keyman.com/keyboards/ -->
Expand All @@ -192,35 +174,14 @@
<category android:name="android.intent.category.DEFAULT" />
<category android:name="android.intent.category.BROWSABLE" />

<data
android:host="keyman-staging.com"
android:scheme="http"
android:pathPrefix="/go/package/download" />

<data
android:host="keyman.com"
android:scheme="https"
android:pathPrefix="/go/package/download" />

</intent-filter>
<data android:host="keyman-staging.com" />
<data android:host="keyman.com" />

<intent-filter android:priority="50">
<!-- KMAPro should also be able to handle /keyboards/install links and convert to /go/package/download -->
<action android:name="android.intent.action.VIEW" />

<category android:name="android.intent.category.DEFAULT" />
<category android:name="android.intent.category.BROWSABLE" />

<data
android:host="keyman-staging.com"
android:scheme="http"
android:pathPrefix="/keyboards/install" />

<data
android:host="keyman.com"
android:scheme="https"
android:pathPrefix="/keyboards/install" />
<data android:scheme="http" />
<data android:scheme="https" />

<data android:pathPrefix="/go/package/download" />
<data android:pathPrefix="/keyboards/install" />
</intent-filter>

</activity>
Expand Down
7 changes: 1 addition & 6 deletions android/KMAPro/kMAPro/src/main/java/com/tavultesoft/kmapro/CheckPermissions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,13 +33,8 @@ public static boolean isPermissionOK(Activity activity) {
// API 30-32
permissionsOK = Environment.isExternalStorageManager() ||
checkPermission(activity, Manifest.permission.READ_EXTERNAL_STORAGE);
} else {
// API 33+
// We had to remove these MEDIA permissions from AndroidManifest.xml so these will end up failing
// https://support.google.com/googleplay/android-developer/answer/14115180?hl=en
permissionsOK = permissionsOK && checkPermission(activity, Manifest.permission.READ_MEDIA_IMAGES);
permissionsOK = permissionsOK && checkPermission(activity, Manifest.permission.READ_MEDIA_VIDEO);
}
// API 33+ does not need any special permissions.

return permissionsOK;
}
Expand Down