Skip to content

Add CMake flags gating Tracking and DCHdigi - #97

Open
madbaron wants to merge 2 commits into
key4hep:mainfrom
madbaron:cleanup_and_configurability
Open

Add CMake flags gating Tracking and DCHdigi#97
madbaron wants to merge 2 commits into
key4hep:mainfrom
madbaron:cleanup_and_configurability

Conversation

@madbaron

@madbaron madbaron commented Sep 1, 2026

Copy link
Copy Markdown
Member

This PR enables the compilation of the package in the muon collider software stack (which doesn't ship Marlin/LCIO, and has an older Delphes version) in preparation for the migration of the charge trasport digitisers discussed in MuonColliderSoft/MuonCVXDDigitiser#17.

BEGINRELEASENOTES

  • Add K4RECTRACKER_TRACKING CMake flag (default=ON) gating the compilation of the FCCee tracking
  • Add K4RECTRACKER_DCH_DIGITISERS CMake flag (default=ON) gating the compilation of the DCH digitisers

ENDRELEASENOTES

The dependencies Tracking on MarlinUtil can actually be cleaned up by using the pandora helix class and a few more things could be streamlined. I'd be happy to take care of these in follow-up PRs if a more general cleanup is desirable!

@tmadlener tmadlener left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stating the obvious first: This will need propagation to the spack and/or lcgcmake packages.

For me nothing speaks against this. I suppose the other option would be to split off the digitisers into a separate repository or package where we have none of these dependencies. We discussed this a while back in a key4hep meeting (notes) and there we concluded to have the tracking related digitizers here. If it simplifies the dependency management I would be open for re-opening that discussion, regardless of what we do with this PR.

@madbaron

madbaron commented Sep 2, 2026

Copy link
Copy Markdown
Member Author

I do think that having digitisers in a place and pattern recognition/tracking software in another would be tidier, especially as k4ActsTracking already sits in its own package, but we can take baby steps on the way there.

I'll be happy to take care of the spack updates as soon as this lands. I don't know where lcgcmake lives :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants