Skip to content

TrackdNdxDelphesBased Fix #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
s6anloes wants to merge 3 commits into
base: main
Choose a base branch
from
Open

TrackdNdxDelphesBased Fix #92

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
127f00c
Attempted fix
s6anloes Aug 7, 2026
9bb4d51
Added protection against 0 return values for nclusters/mm
s6anloes Aug 7, 2026
a59a761
Fix formatting
s6anloes Aug 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions Tracking/components/TrackdNdxDelphesBased.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,17 +109,27 @@ edm4hep::RecDqdxCollection TrackdNdxDelphesBased::operator()(const edm4hep::Trac
double betagamma = momentum / mass;
debug() << "MCParticle betagamma: " << betagamma << endmsg;
// Check if betagamma is in valid range of delphes parametrisation (status: 16 June 2025)
if (betagamma < 0.5 || betagamma > 20000.0) {
warning() << "beta*gamma value outside of \"good\" range of delphes parametrisation (0.5-20000), dN/dx will be "
if (betagamma < 0.5) {
warning() << "beta*gamma value below \"good\" range of delphes parametrisation (0.5-10000), dN/dx will be "

@jmcarcell jmcarcell Aug 7, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment doesn't match, it is below 0.5

@s6anloes s6anloes Aug 12, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I don't see the mismatch?
Could you clarify?

@jmcarcell jmcarcell Aug 20, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant that it is always below 0.5 so it doesn't make sense to say it's below 0.5-10000

"set to dummy value: "
<< dummy_value << " clusters/mm" << endmsg;
goto store_value;
} else if (betagamma > 10000) {
warning() << "beta*gamma value above \"good\" range of delphes parametrisation (0.5-10000), "
"beta*gamma will be set to max value as approximation."
<< endmsg;
betagamma = 9999.9; // 10000 is out of range already
}

// Get number of clusters per length from delphes
// Output from delphes function is in 1/m, so to convert to 1/mm we need to scale accordingly
double nclusters_per_mm = m_delphesTrkUtil.Nclusters(betagamma, m_GasSel.value()) / 1000.0;
debug() << "Number of clusters per mm: " << nclusters_per_mm << endmsg;
if (nclusters_per_mm < 1e-6) {
warning() << "Delphes number of clusters per mm calculation returned 0.0, dN/dx will be set to dummy value: "
<< dummy_value << " clusters/mm" << endmsg;
goto store_value;
}

///////////////////////
// Track Information //
Expand Down
Loading