Skip to content

Rename Tracking folder to avoid shadowing - #91

Closed
Victor-Schwan wants to merge 2 commits into
key4hep:mainfrom
Victor-Schwan:rename-tracking-lib
Closed

Rename Tracking folder to avoid shadowing#91
Victor-Schwan wants to merge 2 commits into
key4hep:mainfrom
Victor-Schwan:rename-tracking-lib

Conversation

@Victor-Schwan

Copy link
Copy Markdown
Contributor

BEGINRELEASENOTES

  • Rename Tracking folder to avoid this generic name which resulted in it being shadowed

ENDRELEASENOTES

@Victor-Schwan

Copy link
Copy Markdown
Contributor Author

Fixes #90

@Victor-Schwan

Copy link
Copy Markdown
Contributor Author

I verified the fix using:

$ cd /home/user/code/k4RecTracker
$ git switch rename-tracking-lib
$ mkdir build install
$ cmake -B build -S . -DCMAKE_INSTALL_PREFIX=./install -G Ninja -DCMAKE_BUILD_TYPE=Debug && cmake --build build --target install
$ k4n
Ubuntu 24.04 detected
Setting up the Key4hep software stack nightly build latest-opt from CVMFS
Use the following command to reproduce the current environment: 

        source /cvmfs/sw-nightlies.hsf.org/key4hep/setup.sh -r 2026-08-05

Nightly builds are intended for testing and development, if you need a stable environment use the releases
If you have any issues, comments or requests, open an issue at https://github.com/key4hep/key4hep-spack/issues
$ python -c "import sys; sys.path.insert(0, '/home/user/code/ILDConfig/StandardConfig/production'); from Configurables import TrackMerger; print(TrackMerger)"
# WARNING: : Module Tracking.TrackingConf not found (needed for configurable TrackMerger)
None
$ k4_local_repo
Added /home/user/code/k4RecTracker/install to the environment and removed any paths containing /k4rectracker/
Some variables may have to be updated manually to point to the local installation
$ python -c "import sys; sys.path.insert(0, '/home/user/code/ILDConfig/StandardConfig/production'); from Configurables import TrackMerger; print(TrackMerger)"
<class 'k4RecTrackerTracking.k4RecTrackerTrackingConf.TrackMerger'>

@Victor-Schwan

Copy link
Copy Markdown
Contributor Author

Locally, the same tests fail on the main branch and the one of this PR

@Victor-Schwan

Copy link
Copy Markdown
Contributor Author

If this PR will be merged, key4hep/key4hep-dev-utils#21 should be updated

@tmadlener

Copy link
Copy Markdown
Member

This is probably obsolete now? Resp. if we do a renaming we want it to follow the common convention of using the package name again?

@Victor-Schwan
Victor-Schwan deleted the rename-tracking-lib branch August 20, 2026 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants