Rename Tracking folder to avoid shadowing - #91
Closed
Victor-Schwan wants to merge 2 commits into
Closed
Conversation
Contributor
Author
|
Fixes #90 |
Contributor
Author
|
I verified the fix using: $ cd /home/user/code/k4RecTracker
$ git switch rename-tracking-lib
$ mkdir build install
$ cmake -B build -S . -DCMAKE_INSTALL_PREFIX=./install -G Ninja -DCMAKE_BUILD_TYPE=Debug && cmake --build build --target install
$ k4n
Ubuntu 24.04 detected
Setting up the Key4hep software stack nightly build latest-opt from CVMFS
Use the following command to reproduce the current environment:
source /cvmfs/sw-nightlies.hsf.org/key4hep/setup.sh -r 2026-08-05
Nightly builds are intended for testing and development, if you need a stable environment use the releases
If you have any issues, comments or requests, open an issue at https://github.com/key4hep/key4hep-spack/issues
$ python -c "import sys; sys.path.insert(0, '/home/user/code/ILDConfig/StandardConfig/production'); from Configurables import TrackMerger; print(TrackMerger)"
# WARNING: : Module Tracking.TrackingConf not found (needed for configurable TrackMerger)
None
$ k4_local_repo
Added /home/user/code/k4RecTracker/install to the environment and removed any paths containing /k4rectracker/
Some variables may have to be updated manually to point to the local installation
$ python -c "import sys; sys.path.insert(0, '/home/user/code/ILDConfig/StandardConfig/production'); from Configurables import TrackMerger; print(TrackMerger)"
<class 'k4RecTrackerTracking.k4RecTrackerTrackingConf.TrackMerger'> |
Contributor
Author
|
Locally, the same tests fail on the |
Contributor
Author
|
If this PR will be merged, key4hep/key4hep-dev-utils#21 should be updated |
Victor-Schwan
force-pushed
the
rename-tracking-lib
branch
from
August 5, 2026 10:49
4d79309 to
0ba3fd3
Compare
1 task
Victor-Schwan
force-pushed
the
rename-tracking-lib
branch
from
August 10, 2026 08:19
0ba3fd3 to
6a23f18
Compare
Member
|
This is probably obsolete now? Resp. if we do a renaming we want it to follow the common convention of using the package name again? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
ENDRELEASENOTES