Skip to content

fix/crash test hardware deselected tree #1996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alanpeixinho merged 1 commit into from
Jul 17, 2026
+94 −97
Merged

fix/crash test hardware deselected tree #1996

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 31 additions & 32 deletions dashboard/src/components/BootsTable/BootsTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,10 +305,29 @@ export function BootsTable({
[modelRows],
);

const [currentLog, setLog] = useState<number | undefined>(undefined);
const [currentLogId, setLog] = useState<string | undefined>(undefined);

const currentLog = useMemo(() => {
const index = sortedItems.findIndex(item => item.id === currentLogId);
return index === -1 ? undefined : index;
}, [sortedItems, currentLogId]);

const activeLogId = currentLog !== undefined ? currentLogId ?? '' : '';

const onOpenChange = useCallback(() => setLog(undefined), [setLog]);
const openLogSheet = useCallback((index: number) => setLog(index), [setLog]);
const openLogSheet = useCallback(
(index: number) => setLog(sortedItems[index]?.id),
[setLog, sortedItems],
);

useEffect(() => {
if (
currentLogId !== undefined &&
!sortedItems.some(item => item.id === currentLogId)
) {
setLog(undefined);
}
}, [currentLogId, sortedItems]);

const tableRows = useMemo((): JSX.Element[] | JSX.Element => {
return modelRows?.length ? (
Expand All @@ -332,32 +351,18 @@ export function BootsTable({
}, [modelRows, getRowLink, openLogSheet, currentLog, columns.length]);

const handlePreviousItem = useCallback(() => {
setLog(previousLog => {
if (typeof previousLog === 'number' && previousLog > 0) {
return previousLog - 1;
}

return previousLog;
});
}, [setLog]);
if (currentLog !== undefined && currentLog > 0) {
setLog(sortedItems[currentLog - 1]?.id);
}
}, [setLog, currentLog, sortedItems]);

const handleNextItem = useCallback(() => {
setLog(previousLog => {
if (
typeof previousLog === 'number' &&
previousLog < sortedItems.length - 1
) {
return previousLog + 1;
}

return previousLog;
});
}, [setLog, sortedItems.length]);
if (currentLog !== undefined && currentLog < sortedItems.length - 1) {
setLog(sortedItems[currentLog + 1]?.id);
}
}, [setLog, currentLog, sortedItems]);

const { data: logData, isLoading } = useLogData(
sortedItems.length > 0 ? sortedItems[currentLog ?? 0].id : '',
'test',
);
const { data: logData, isLoading } = useLogData(activeLogId, 'test');

const navigationLogsActions = useMemo(
() => ({
Expand All @@ -381,13 +386,7 @@ export function BootsTable({
return getRowLink(logData?.id ?? '');
}, [logData?.id, getRowLink]);

const {
data: issues,
status,
error,
} = useTestIssues(
currentLog !== undefined ? sortedItems[currentLog]?.id : '',
);
const { data: issues, status, error } = useTestIssues(activeLogId);

return (
<WrapperTableWithLogSheet
Expand Down
63 changes: 31 additions & 32 deletions dashboard/src/components/BuildsTable/BuildsTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,10 +197,29 @@ export function BuildsTable({
[modelRows],
);

const [currentLog, setLog] = useState<number | undefined>(undefined);
const [currentLogId, setLog] = useState<string | undefined>(undefined);

const currentLog = useMemo(() => {
const index = sortedItems.findIndex(item => item.id === currentLogId);
return index === -1 ? undefined : index;
}, [sortedItems, currentLogId]);

const activeLogId = currentLog !== undefined ? currentLogId ?? '' : '';

const onOpenChange = useCallback(() => setLog(undefined), [setLog]);
const openLogSheet = useCallback((index: number) => setLog(index), [setLog]);
const openLogSheet = useCallback(
(index: number) => setLog(sortedItems[index]?.id),
[setLog, sortedItems],
);

useEffect(() => {
if (
currentLogId !== undefined &&
!sortedItems.some(item => item.id === currentLogId)
) {
setLog(undefined);
}
}, [currentLogId, sortedItems]);

const tableBody = useMemo((): JSX.Element[] | JSX.Element => {
{
Expand Down Expand Up @@ -228,32 +247,18 @@ export function BuildsTable({
}, [modelRows, columns.length, openLogSheet, currentLog, getRowLink]);

const handlePreviousItem = useCallback(() => {
setLog(previousLog => {
if (typeof previousLog === 'number' && previousLog > 0) {
return previousLog - 1;
}

return previousLog;
});
}, [setLog]);
if (currentLog !== undefined && currentLog > 0) {
setLog(sortedItems[currentLog - 1]?.id);
}
}, [setLog, currentLog, sortedItems]);

const handleNextItem = useCallback(() => {
setLog(previousLog => {
if (
typeof previousLog === 'number' &&
previousLog < sortedItems.length - 1
) {
return previousLog + 1;
}

return previousLog;
});
}, [setLog, sortedItems.length]);
if (currentLog !== undefined && currentLog < sortedItems.length - 1) {
setLog(sortedItems[currentLog + 1]?.id);
}
}, [setLog, currentLog, sortedItems]);

const { data: logData, isLoading } = useLogData(
sortedItems.length > 0 ? sortedItems[currentLog ?? 0]?.id : '',
'build',
);
const { data: logData, isLoading } = useLogData(activeLogId, 'build');

const navigationLogsActions = useMemo(
() => ({
Expand All @@ -277,13 +282,7 @@ export function BuildsTable({
return getRowLink(sortedItems[currentLog ?? 0]?.id ?? '');
}, [currentLog, getRowLink, sortedItems]);

const {
data: issues,
status,
error,
} = useBuildIssues(
currentLog !== undefined ? sortedItems[currentLog]?.id : '',
);
const { data: issues, status, error } = useBuildIssues(activeLogId);

return (
<WrapperTableWithLogSheet
Expand Down
65 changes: 32 additions & 33 deletions dashboard/src/components/TestsTable/IndividualTestsTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import {
} from '@tanstack/react-table';
import { useVirtualizer } from '@tanstack/react-virtual';
import type { CSSProperties, JSX } from 'react';
import { useCallback, useMemo, useRef, useState } from 'react';
import { useCallback, useEffect, useMemo, useRef, useState } from 'react';

import type { LinkProps } from '@tanstack/react-router';

Expand Down Expand Up @@ -87,10 +87,29 @@ export function IndividualTestsTable({
[modelRows],
);

const [currentLog, setLog] = useState<number | undefined>(undefined);
const [currentLogId, setLog] = useState<string | undefined>(undefined);

const currentLog = useMemo(() => {
const index = originalItems.findIndex(item => item.id === currentLogId);
return index === -1 ? undefined : index;
}, [originalItems, currentLogId]);

const activeLogId = currentLog !== undefined ? currentLogId ?? '' : '';

const onOpenChange = useCallback(() => setLog(undefined), [setLog]);
const openLogSheet = useCallback((index: number) => setLog(index), [setLog]);
const openLogSheet = useCallback(
(index: number) => setLog(originalItems[index]?.id),
[setLog, originalItems],
);

useEffect(() => {
if (
currentLogId !== undefined &&
!originalItems.some(item => item.id === currentLogId)
) {
setLog(undefined);
}
}, [currentLogId, originalItems]);

const tableRows = useMemo((): JSX.Element[] => {
return virtualItems.map(virtualRow => {
Expand Down Expand Up @@ -126,32 +145,18 @@ export function IndividualTestsTable({
}, [virtualItems, virtualizer]);

const handlePreviousItem = useCallback(() => {
setLog(previousLog => {
if (typeof previousLog === 'number' && previousLog > 0) {
return previousLog - 1;
}

return previousLog;
});
}, [setLog]);
if (currentLog !== undefined && currentLog > 0) {
setLog(originalItems[currentLog - 1]?.id);
}
}, [setLog, currentLog, originalItems]);

const handleNextItem = useCallback(() => {
setLog(previousLog => {
if (
typeof previousLog === 'number' &&
previousLog < originalItems.length - 1
) {
return previousLog + 1;
}

return previousLog;
});
}, [setLog, originalItems.length]);
if (currentLog !== undefined && currentLog < originalItems.length - 1) {
setLog(originalItems[currentLog + 1]?.id);
}
}, [setLog, currentLog, originalItems]);

const { data: logData, isLoading } = useLogData(
originalItems.length > 0 ? originalItems[currentLog ?? 0].id : '',
'test',
);
const { data: logData, isLoading } = useLogData(activeLogId, 'test');

const navigationLogsActions = useMemo(
() => ({
Expand All @@ -175,13 +180,7 @@ export function IndividualTestsTable({
return getRowLink(logData?.id ?? '');
}, [logData?.id, getRowLink]);

const {
data: issues,
status,
error,
} = useTestIssues(
currentLog !== undefined ? originalItems[currentLog]?.id : '',
);
const { data: issues, status, error } = useTestIssues(activeLogId);

return (
<WrapperTableWithLogSheet
Expand Down
Loading