Repository navigation
feat: confirm before exiting CCManager - #334
Merged
Merged
Conversation
Exiting from the menu or the multi-project list used to terminate every active session immediately with no way back. Add a confirmation dialog (defaulting to Cancel) that also reports how many sessions would be terminated, since they can still be restored on the next launch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
Both exit entry points — the single-project menu's "Exit" action (
q/xor selecting the row) and the multi-project list's "Exit" row — calledglobalSessionOrchestrator.destroyAllSessions()andexit()directly. A stray keypress or a wrong selection immediately killed every running session with no confirmation step, unlike other destructive actions in the app (e.g. deleting a worktree), which already prompt first.Verification
Prerequisites:
bun install).Steps:
bun run lintbun run typecheckbun run test(full suite, run twice to check for flakiness) — all passsrc/components/App.test.tsxcover: canceling returns to the menu without destroying sessions, confirming destroys sessions and exits, and the same confirm flow from the multi-project list