fix: fix triangulate#1103
Open
dragoncoder047 wants to merge 8 commits into
Open
Conversation
Contributor
Author
|
before: 
after: 
|
lajbel
requested changes
Jun 30, 2026
| * @returns flattened list of indices of each of the decomposed triangles, list will always have a multiple of 3 length | ||
| */ | ||
| triangulate(pts: Vec2[]): Vec2[][]; | ||
| triangulate(pts: Vec2[]): number[]; |
Member
There was a problem hiding this comment.
would you explain why it doesnt return Vec2 anymore?
Contributor
Author
There was a problem hiding this comment.
the only place that triangulate was used really inside kaplay at least is to compute the indices for the polygon triangulation and making triangulate() return the format that the polygon needs results in less conversion overhead and less wasted memory
Contributor
Author
There was a problem hiding this comment.
see drawPolygon.ts
Member
|
If you have time would be cool your review here @mflerackers |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1100