fix: button release on blur#1101
Merged
Merged
Conversation
imaginarny
requested changes
Jun 12, 2026
imaginarny
left a comment
imaginarny
left a comment
Member
There was a problem hiding this comment.
This was on todo so it would be great help again as well. 🙂
Will test some more once its updated and could merge it before #1106 so you have less work merging conflicts. Plus, I have one another in progress that could cause troubles as well, so would make sense to merge this one first.
Stanko
force-pushed
the
release-keys-on-window-blur
branch
from
June 12, 2026 19:13
107a45d to
62d75eb
Compare
2 tasks
Member
|
Would merge once you update the branch and changelog it. |
Stanko
force-pushed
the
release-keys-on-window-blur
branch
from
June 25, 2026 12:44
62d75eb to
7a6ef35
Compare
Stanko
marked this pull request as ready for review
June 25, 2026 12:44
Contributor
Author
|
Done and done 🙌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #1094
I would like you folks to take a look before I convert it to a "real" pull request.
I added "release all" buttons for keyboard and mouse. These events can "drop" when focus leaves the canvas. On the other hand gamepad is polling for events so I made sure to skip those (if there are any).