Repository navigation
Fix update checks for OCI tags and yanked chart versions - #1353
Merged
Merged
Conversation
agent-gateway: the 'v' prefix was stripped from v2.2.1 and 2.2.1 written to st-charts.yaml, but an OCI registry is addressed by tag, so every later 'helm show chart --version' failed. Record the tag for OCI and keep stripping only for https, where the index is keyed by the chart version. mysql: mysql-operator keeps only the latest version in its index, so querying the appVersion of 2.2.3 aborted the whole app. Warn and reuse the appVersion already in charts.yaml instead.
During a tagging convention change a registry can carry both spellings of one release (agentgateway has 1.1.0 and v1.1.0). Equal versions were resolved by whichever the registry returned first, so the recorded version could flip between runs and open a cosmetic update PR. Prefer the tag already in st-charts.yaml, then its prefix style.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
agent-gateway: the 'v' prefix was stripped from v2.2.1 and 2.2.1 written to st-charts.yaml, but an OCI registry is addressed by tag, so every later 'helm show chart --version' failed. Record the tag for OCI and keep stripping only for https, where the index is keyed by the chart version.
mysql: mysql-operator keeps only the latest version in its index, so querying the appVersion of 2.2.3 aborted the whole app. Warn and reuse the appVersion already in charts.yaml instead.