feat(approval-indicator): pause spinner while awaiting confirmation - #202
Closed
cbusillo wants to merge 1 commit into
Closed
feat(approval-indicator): pause spinner while awaiting confirmation#202cbusillo wants to merge 1 commit into
cbusillo wants to merge 1 commit into
Conversation
cbusillo
force-pushed
the
feat-approval-indicator
branch
2 times, most recently
from
September 25, 2025 20:05
4cc041a to
a772f21
Compare
cbusillo
force-pushed
the
feat-approval-indicator
branch
from
September 26, 2025 03:07
a772f21 to
3528bb6
Compare
zemaj
force-pushed
the
main
branch
2 times, most recently
from
October 28, 2025 23:57
804b5ad to
b7927a2
Compare
|
Thanks! Since c8111bb moved the maintained TUI into code-rs/, the codex-rs directory is now read-only mirror of openai/codex. I’m going to close this to prevent drift—if we still need the approval indicator tweak, let’s re-open it against the code-rs tree. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces the following changes:
This allows a user to see the current status of a session at a glance just from the window/tab title. Currently the spinner makes it appear like the session is running, when really its paused for a confirmation.