Skip to content

[shift-tab-crash] fix(core/config): prevent panic on Shift+Tab when projects is not a table #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zemaj merged 1 commit into from
Sep 18, 2025
Merged

[shift-tab-crash] fix(core/config): prevent panic on Shift+Tab when projects is not a table #195

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 17 additions & 4 deletions codex-rs/core/src/config.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -821,17 +821,30 @@ pub fn set_project_access_mode(

// Ensure projects table and the per-project table exist
let project_key = project_path.to_string_lossy().to_string();
if !doc.as_table().contains_key("projects") {
// Ensure `projects` is a table; if key exists but is not a table, replace it.
let has_projects_table = doc
.as_table()
.get("projects")
.and_then(|i| i.as_table())
.is_some();
if !has_projects_table {
doc["projects"] = TomlItem::Table(toml_edit::Table::new());
}
let projects_tbl = doc["projects"].as_table_mut().unwrap();
if !projects_tbl.contains_key(project_key.as_str()) {
let Some(projects_tbl) = doc["projects"].as_table_mut() else {
return Err(anyhow::anyhow!("failed to prepare projects table"));
};
// Ensure per-project entry exists and is a table; replace if wrong type.
let needs_proj_table = projects_tbl
.get(project_key.as_str())
.and_then(|i| i.as_table())
.is_none();
if needs_proj_table {
projects_tbl.insert(project_key.as_str(), TomlItem::Table(toml_edit::Table::new()));
}
let proj_tbl = projects_tbl
.get_mut(project_key.as_str())
.and_then(|i| i.as_table_mut())
.ok_or_else(|| anyhow::anyhow!("failed to create projects.{} table", project_key))?;
.ok_or_else(|| anyhow::anyhow!(format!("failed to create projects.{} table", project_key)))?;

// Write fields
proj_tbl.insert(
Expand Down
Loading