refactor: extract shared parseTimestamp utility to avoid duplication - #30
Open
MayurK-cmd wants to merge 1 commit into
Open
refactor: extract shared parseTimestamp utility to avoid duplication#30MayurK-cmd wants to merge 1 commit into
MayurK-cmd wants to merge 1 commit into
Conversation
Both SpotCommand and PerpsCommand had duplicate parseTimestamp() methods with inconsistent behavior. Created shared DateConverter.parseTimestamp() utility to ensure consistent timestamp handling across all commands. Changes: - Create src/lib/DateConverter.ts with parseTimestamp() method - Update SpotCommand to use DateConverter.parseTimestamp() - Update PerpsCommand to use DateConverter.parseTimestamp() - Reduces code duplication by 2 implementations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor: extract shared parseTimestamp utility to avoid duplication
Both
SpotCommandandPerpsCommandimplemented identical parseTimestamp()logic to convert user input (ISO dates or UNIX timestamps) to Unix seconds.
This duplication made maintenance harder and created risk if timestamp
handling needed to change.
Created new
DateConverterutility class with a sharedparseTimestamp()method that both commands now use. This ensures consistent behavior across
all commands that need to parse timestamps.
Changes:
No functional changes — same behavior, less code.
Fixes: #25