Skip to content

fix: add warning for missing token metadata in spot portfolio #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MayurK-cmd wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: add warning for missing token metadata in spot portfolio #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/commands/SpotCommand.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -400,6 +400,9 @@ export class SpotCommand {
}
const info = tokenMap.get(mint);
if (!info) {
console.warn(
`Warning: Could not fetch metadata for token ${mint}. Skipping.`
);
continue;
}
const multiplier = Swap.getScaledUiMultiplier(info);
Expand Down
10 changes: 10 additions & 0 deletions src/e2e.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,3 +106,13 @@ describe("keys add (dist/index.js)", () => {
expect(second.stdout + second.stderr).toContain("already exists");
});
});

describe("spot portfolio", () => {
test("handles portfolio lookup without crashing on missing metadata", () => {
// This test verifies that the command completes without crashing
// even if token metadata is unavailable
const result = runCli("spot", "portfolio", "--address", TEST_SEED_ADDRESS);
// Should complete (may fail on API, but not crash on missing metadata)
expect(result.status).toBeLessThanOrEqual(1);
});
});