fix: gracefully handle corrupted keypair files in keys list - #28
Open
MayurK-cmd wants to merge 1 commit into
Open
fix: gracefully handle corrupted keypair files in keys list#28MayurK-cmd wants to merge 1 commit into
MayurK-cmd wants to merge 1 commit into
Conversation
Previously, if any keypair file was corrupted or unreadable, the entire 'keys list' command would crash due to Promise.all() rejecting. Now uses Promise.allSettled() to load all valid keys and warn about failed ones. Changes: - Replace Promise.all() with Promise.allSettled() - Track failed keys and display warning message - Add e2e test verifying command succeeds with corrupted files present
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: gracefully handle corrupted keypair files in keys list
Previously, if any keypair file was corrupted or unreadable, the entire
'keys list' command would crash due to Promise.all() rejecting on first
error. Now uses Promise.allSettled() to:
Changes:
Fixes: #23