Repository navigation
fix dockerfile build args & allow to disable group-backup - #78
Merged
Merged
Conversation
Signed-off-by: Xuhui zhang <xuhui@juicedata.io>
Signed-off-by: Xuhui zhang <xuhui@juicedata.io>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes dockerfile build arguments and allows disabling group-backup functionality. The main purpose is to enable proper build-time configuration through ldflags and provide flexibility in backup worker configuration.
- Add ldflags support to dockerfile build process for better binary configuration
- Allow setting
backupDuration: 0sto disable automatic group-backup option for new cache group workers - Refactor binary naming from
managertojuicefs-operatorfor consistency
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| internal/controller/cachegroup_controller.go | Adds logic to disable group-backup when backup duration is minimal |
| go.mod | Moves k8s.io/klog/v2 from indirect to direct dependency |
| cmd/app/manager.go | Changes from GetClient() to GetAPIReader() for pod retrieval |
| Makefile | Adds LDFLAGS build argument to docker buildx command |
| Dockerfile | Adds LDFLAGS support and renames binary from manager to juicefs-operator |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
zwwhdls
approved these changes
Sep 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backupDuration: 0sto disable automatic group-backup option for new cache group workersmanagertojuicefs-operatorfor kueb-apiserver access log