Skip to content

fix dockerfile build args & allow to disable group-backup - #78

Merged
zxh326 merged 3 commits into
mainfrom
fix-build-script
Sep 9, 2025
Merged

zxh326 merged 3 commits into
mainfrom
fix-build-script

Conversation

@zxh326

@zxh326 zxh326 commented Sep 8, 2025 •

Copy link
Copy Markdown
Member
  • Add ldflags support to dockerfile build process for better binary configuration
  • Allow setting backupDuration: 0s to disable automatic group-backup option for new cache group workers
  • Refactor binary naming from manager to juicefs-operator for kueb-apiserver access log

Signed-off-by: Xuhui zhang <xuhui@juicedata.io>
Signed-off-by: Xuhui zhang <xuhui@juicedata.io>
Signed-off-by: Xuhui zhang <xuhui@juicedata.io>
@zxh326
zxh326 requested a review from Copilot September 8, 2025 08:21

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes dockerfile build arguments and allows disabling group-backup functionality. The main purpose is to enable proper build-time configuration through ldflags and provide flexibility in backup worker configuration.

  • Add ldflags support to dockerfile build process for better binary configuration
  • Allow setting backupDuration: 0s to disable automatic group-backup option for new cache group workers
  • Refactor binary naming from manager to juicefs-operator for consistency

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
internal/controller/cachegroup_controller.go Adds logic to disable group-backup when backup duration is minimal
go.mod Moves k8s.io/klog/v2 from indirect to direct dependency
cmd/app/manager.go Changes from GetClient() to GetAPIReader() for pod retrieval
Makefile Adds LDFLAGS build argument to docker buildx command
Dockerfile Adds LDFLAGS support and renames binary from manager to juicefs-operator

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread internal/controller/cachegroup_controller.go
@zxh326
zxh326 requested a review from zwwhdls September 8, 2025 08:27
@zxh326
zxh326 merged commit 932e147 into main Sep 9, 2025
3 checks passed
@zxh326
zxh326 deleted the fix-build-script branch September 9, 2025 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants