feat(modeling): preserve color for offset and extrude - #1275
Merged
Conversation
platypii
force-pushed
the
V3-preserve-color
branch
from
August 10, 2023 04:06
16e43a3 to
a51b299
Compare
platypii
force-pushed
the
V3-preserve-color
branch
from
August 10, 2023 04:35
a51b299 to
b117448
Compare
hrgdavor
previously approved these changes
Aug 10, 2023
hrgdavor
left a comment
Contributor
There was a problem hiding this comment.
This a move in right direction. Colors from boolean ops were removed for perf gain, but it is possible we will be able to make keeping colors optional in the future for booleans.
z3dev
requested changes
Aug 12, 2023
Contributor
Author
|
@z3dev I just pushed some more changes which I hope will address your concerns:
Let me know what you think |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR preserves the color attribute when applying operations like
offsetandextrudeandproject.This seems like a clear improvement for users of JSCAD. If you have a 2D object with color like on the left, would you expect extrusion to preserve the color? Or lose it?
preserve-color.js
If someone really want no color, it's easy to remove using
colorize. But if you want to preserve color of sub-components through an operation... there's really no good way to do it without this change.All Submissions: