Make PSF Loader functions protected - #1609
Open
kode54 wants to merge 1 commit into
Open
Conversation
This will allow an external implementation to derive from the class, such as for loading PSF rips from custom CPsfStreamProvider classes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will allow an external implementation to derive from the class, such as for loading PSF rips from custom CPsfStreamProvider classes.
I do intend to make a better interface for this, or at least request one.
I would also like to change the deeper interface classes so they accept the top level PSF file class instance directly instead of allocating it themselves, so that the filtering for specific format types is handled by the GetVersion() return value, rather than detecting from the filename.