Fix TCX export for non-GPS activities (#1337) - #1379
Open
roberi wants to merge 1 commit into
Open
Conversation
Correct parameter mapping when calling shouldExportLap(). Swapped lap time and distance arguments caused laps with duration but no distance to be excluded from TCX exports.
There was a problem hiding this comment.
Pull request overview
Fixes TCX lap-export filtering for non-GPS activities by passing lap distance/time to ExportOptions.shouldExportLap() in the correct order, ensuring laps with duration but no distance are not incorrectly omitted (which caused Strava to reject the TCX due to missing time information).
Changes:
- Corrected the argument order (distance vs time) in
TCX.exportLaps()when callingExportOptions.shouldExportLap().
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1337
Non-GPS activities, such as Gym workouts, could be exported without lap data, resulting in incomplete TCX files that Strava rejected for missing activity time information.
In
TCX.exportLaps(), the call toExportOptions.shouldExportLap()passed lap time and distance values in the wrong order. As a result, laps from activities with a duration but no distance were incorrectly filtered out during export.After swapping the time and distance arguments in the
shouldExportLap()call, Gym and other non-GPS activities can now be successfully uploaded to Strava.Note! There is still a separate issue related to how Strava interprets non-GPS activities when GPS-related fields are present in the exported TCX file, but this is outside the scope of this PR.