Skip to content

Close BufferedWriter in upload #1360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tejas-ae wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Close BufferedWriter in upload #1360

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 23 additions & 22 deletions app/src/main/org/runnerup/export/RunKeeperSynchronizer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -462,29 +462,30 @@ public Status upload(SQLiteDatabase db, final long mID) {
conn.addRequestProperty(
"Content-type", "application/vnd.com.runkeeper.NewFitnessActivity+json");
RunKeeper rk = new RunKeeper(db, simplifier);
BufferedWriter w = new BufferedWriter(new OutputStreamWriter(conn.getOutputStream()));
rk.export(mID, w);
w.flush();

int responseCode = conn.getResponseCode();
String amsg = conn.getResponseMessage();
String externalId = noNullStr(conn.getHeaderField("Location"));
conn.disconnect();
conn = null;

if (responseCode >= HttpURLConnection.HTTP_OK
&& responseCode < HttpURLConnection.HTTP_MULT_CHOICE) {
s.activityId = mID;
if (!TextUtils.isEmpty(externalId)) {
s.externalId = externalId;
s.externalIdStatus = ExternalIdStatus.OK;
}
return s;
try (BufferedWriter w = new BufferedWriter(new OutputStreamWriter(conn.getOutputStream()))) {
rk.export(mID, w);
w.flush();

int responseCode = conn.getResponseCode();
String amsg = conn.getResponseMessage();
String externalId = noNullStr(conn.getHeaderField("Location"));
conn.disconnect();
conn = null;

if (responseCode >= HttpURLConnection.HTTP_OK
&& responseCode < HttpURLConnection.HTTP_MULT_CHOICE) {
s.activityId = mID;
if (!TextUtils.isEmpty(externalId)) {
s.externalId = externalId;
s.externalIdStatus = ExternalIdStatus.OK;
}
return s;
}
Log.e(getName(), "Error code: " + responseCode + ", amsg: " + amsg);
ex = new Exception(amsg);
} catch (Exception e) {
ex = e;
}
Comment on lines +465 to 488
Log.e(getName(), "Error code: " + responseCode + ", amsg: " + amsg);
ex = new Exception(amsg);
} catch (Exception e) {
ex = e;
}

Log.e(getName(), "Failed to upload: " + ex.getMessage());
Expand Down
Loading