diff: honor wrap-lines for commit titles - #1447
Open
timotheecour wants to merge 1 commit into
Open
timotheecour wants to merge 1 commit into
timotheecour wants to merge 1 commit into
Conversation
Route the specially marked commit-title row through the common pager reader so it follows the same wrap-lines behavior as the surrounding diff metadata. Add a focused display regression for a long subject. Fixes jonas#1446.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pager_common_read, like surrounding diff metadatacommit_titlemarker on the first rendered rowwrap-lines = trueFixes #1446.
Tests
make test— 572 assertions in 153 tests passed (1 skipped)