Handle missing runtimes and add runtime sanity checking - #57
Merged
joepetrowski merged 5 commits intoJun 8, 2026
Merged
Conversation
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
joepetrowski
approved these changes
Jun 8, 2026
seadanda
approved these changes
Jun 8, 2026
| let runtime = response.bytes().await.expect("need bytes"); | ||
|
|
||
| if !upgrade_details.no_runtime_checks { | ||
| // Substrate zstd-compressed blob magic (`sp_maybe_compressed_blob::ZSTD_PREFIX`). |
Contributor
Author
There was a problem hiding this comment.
That is private, but I guess you could call decompress.
Collaborator
There was a problem hiding this comment.
ah fair enough, magic string is fine for something so unlikely to ever change
Collaborator
|
Ah already merged, I'll make a follow up to fix those few lines in the tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Somehow all the runtimes downloaded by OpenGov-CLI showed the same hash; turns out that hash was the
blake2of the GitHub 404 reply 😅Changes:
no_runtime_checksto skip runtime checks