Skip to content

chore(examples): drop the Node 22 engines override for StackBlitz - #473

Merged
joe-bell merged 2 commits into
mainfrom
claude/project-thread-ss1nsa
Nov 6, 2026
Merged

joe-bell merged 2 commits into
mainfrom
claude/project-thread-ss1nsa

Conversation

@joe-bell

@joe-bell joe-bell commented Nov 6, 2026 •

Copy link
Copy Markdown
Owner

Requested by Joe · project thread

Description

StackBlitz WebContainers now support Node 24 (stackblitz/webcontainer-core#560), so the examples no longer need their own permissive engines.node range.

  • Removes the "Examples allow Node >=22" syncpack version group from the root package.json, so the examples snap to the root engines.node ("24") like every other package that declares it.
  • Updates all 14 examples/*/*/package.json files from ">=22" to "24" (via pnpm syncpack:fix).
  • Updates the Node.js versions section of CONTRIBUTING.md and the matching lines in AGENTS.md: StackBlitz picks the WebContainer's Node version from engines.node, the examples follow the root pin, and a future Node bump should first check that WebContainers can run the new version.

Additional context

No lockfile change: pnpm install --frozen-lockfile is up to date and syncpack lint passes. No packages/cva changes, so the beta What's New page is unaffected.

Verified in StackBlitz from this branch with headless Chromium, running node -v in each project's terminal:

  • main (">=22") runs Node v22.22.3; this branch ("24") runs Node v24.22.2.
  • beta/react-with-tailwindcss, beta/vue, beta/svelte, beta/astro-with-tailwindcss and latest/react-with-css-modules all install cleanly with no EBADENGINE or "Unsupported engine" warnings, start their dev server, and render the preview.

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Follow the Style Guide.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).

🤖 Generated with Claude Code

https://claude.ai/code/session_018U2SotbBBJGvHh6AZvfsux

StackBlitz WebContainers now support Node 24, so the examples no longer
need their own ">=22" engines range. Remove the dedicated syncpack
version group so the examples snap to the root engines.node like every
other package, and update the contributor docs to match.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018U2SotbBBJGvHh6AZvfsux
@joe-bell joe-bell self-assigned this Nov 6, 2026
@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
cva a020d47 Commit Preview URL

Branch Preview URL
Nov 06 2026, 01:21 PM

joe-bell commented Nov 6, 2026

Copy link
Copy Markdown
Owner Author

@codex review


Generated by Claude Code

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 6, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-06T14:02:57.528086Z 4750a2e Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Delightful!

Reviewed commit: a020d4777e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Verified in StackBlitz: an example with ">=22" runs on Node 22.22.3 and
one with "24" runs on Node 24.22.2. Record that, plus the one-at-a-time
gotcha when driving StackBlitz from a headless browser.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018U2SotbBBJGvHh6AZvfsux
@joe-bell
joe-bell marked this pull request as ready for review November 6, 2026 13:58

joe-bell commented Nov 6, 2026

Copy link
Copy Markdown
Owner Author

@codex review


Generated by Claude Code

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Keep them coming!

Reviewed commit: 4750a2e6f7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@joe-bell
joe-bell merged commit fc041f2 into main Nov 6, 2026
12 of 13 checks passed
@joe-bell
joe-bell deleted the claude/project-thread-ss1nsa branch November 6, 2026 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants