Repository navigation
ci: finish Dependabot npm updates; bump vite and astro - #472
Merged
Merged
Conversation
Applies Dependabot's security updates from #469 and #471 across the whole workspace: vite ^8.1.6 in every package that uses it, astro 7.3.3 in the docs and both Astro examples, and a regenerated lockfile. The lockfile now resolves a single vite 8.3.5, which also clears the 8.2.2 copy affected by the same advisories. Drops the root `vite` override from pnpm-workspace.yaml. It changed no resolution (removing it leaves every resolved version identical), but syncpack lints it against the manifests and nothing that bumps vite edits it, which is what failed #469. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018U2SoucjTmuQfNcw9V1K3n
Dependabot's npm support stops at pnpm 10, so its security updates for this pnpm 11 workspace arrive half done: a workspace-package update (#471, "in /docs") leaves pnpm-lock.yaml stale and every frozen install fails, and a bump can miss other packages pinning the same dependency, failing syncpack. The new `dependabot / sync` job runs on Dependabot's pushes to its own npm branches, aligns versions with the base branch's syncpack, regenerates the lockfile with a lockfile-only install, and pushes one commit. It executes no dependency code and hands GITHUB_TOKEN only to the push step. REVIEW.md and .github/AGENTS.md record the guards that keep it safe. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018U2SoucjTmuQfNcw9V1K3n
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
cva | 23a9f4a | Commit Preview URL Branch Preview URL |
Nov 02 2026, 01:25 PM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Joe · project thread
Description
Supersedes #469 and #471, and stops the next Dependabot npm PR from failing the same way.
Why they failed
"vite": "^8.1.0"override inpnpm-workspace.yaml, sosyncpack lintfailed (DiffersToHighestOrLowestSemver).docs/package.json. The lockfile was left stale, so everypnpm install --frozen-lockfilefailed (ERR_PNPM_OUTDATED_LOCKFILE), and that took down every CI job and the Workers build. It also skipped the two Astro examples that pin the same version. Dependabot's npm support stops at pnpm 10 and this workspace pins pnpm 11 (already noted inREVIEW.md), so these security updates can't be trusted to finish the job.Changes
vite^8.1.6everywhere,astro7.3.3indocsand both Astro examples, and a regenerated lockfile. The lockfile now resolves a singlevite@8.3.5, which also clears the8.2.2copy onmainthatpnpm auditflags under the same advisories. After this,pnpm auditreports noviteorastroadvisories.viteoverride. Removing it leaves every resolved version the same, but nothing that bumps vite (Dependabot orsyncpack fix) editspnpm-workspace.yaml, so every vite bump would fail syncpack.AGENTS.mdnow says not to override packages that a workspace manifest depends on directly..github/workflows/dependabot.yml(dependabot / sync). It runs on Dependabot's pushes to its owndependabot/npm_and_yarn/*branches. It runssyncpack fix(the base branch's pinned version) and then a lockfile-onlypnpm install, and pushes onechore(deps): sync …commit when anything changed. On the ci: bump astro from 7.3.1 to 7.3.3 in /docs #471 state this produces exactly the fix in this PR (verified locally: syncpack bumps both examples, and the regenerated lockfile passes--frozen-lockfile).Additional context
pull_requestjob that can write to the repo (contents: write), so please review it as a privileged job. It runs no dependency or PR code. syncpack is installed outside the checkout from the public registry with--ignore-scripts, and pnpm runs with--lockfile-only --ignore-scripts --ignore-pnpmfile. The checkout keeps no credentials, andGITHUB_TOKENreaches only the push step. Its own push (actorgithub-actions[bot]), maintainer pushes and forks all skip the job, so it can't loop.REVIEW.mdlists these guards.GITHUB_TOKEN, so the repaired PR'spull_requestruns wait ataction_required(same behaviourweekly.ymldocuments) until you approve them. A Dependabot secret holding a PAT would avoid that, but it would put an owner credential in Dependabot runs, so I left it out.minimumReleaseAge(3 days), the lockfile step fails. Re-run it once the release is old enough.packages/cvachanges, so the beta What's New page is unaffected.syncpack:lint,check,test(100% coverage),build:examples,pnpm --filter docs build,bundlesize(sizes unchanged).mainand not touched here:undici(the existing override needs^7.30.1),zod,@vitest/mocker,@vue/server-renderer,fast-uri,minimatch,postcss-selector-parser,deepmerge.What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).Generated by Claude Code