Correct class naming for the inspector - #33
Open
nnseva wants to merge 2 commits into
Open
Conversation
Owner
|
This seems intriguing. I'd like to see some performance numbers on it though, since it introduces a string eval, and I'm not sure how that plays with VMs |
Author
|
The string eval may take some performance penalty, but I think it should not affect the production code noticable in this case, because this penalty will aply only to class (metaclass object) creation code, while the instance creation code should not be affected. |
Owner
|
I believe that's true too, but I would like to see it tested and verified. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Doing trick like proposed we are passing correct names to the inspector.
What is not good, I don't know how to check inspector behaviour correctly. Really I've checked it in the browser manually, so you might wish to improve the testcases.