Skip to content

Address launch profile review feedback - #15

Merged
jennyf19 merged 1 commit into
mainfrom
fix/review-feedback
Aug 4, 2026
Merged

jennyf19 merged 1 commit into
mainfrom
fix/review-feedback

Conversation

@jennyf19

@jennyf19 jennyf19 commented Aug 4, 2026

Copy link
Copy Markdown
Owner

Summary

Address the three GitHub Copilot review comments raised while distributing the cost-aware Workshop profiles:

  • execute trusted Windows .cmd/.bat Copilot or Agency shims through System32 cmd.exe with correct /S /C quoting
  • increase the connected launch button's default contrast
  • document WORKSHOP_DESK_PROFILE=connected behavior

Percent-bearing shim paths fail discovery open-to-connected rather than risk cmd expansion.

Validation

  • 8 launch-profile tests pass
  • Windows integration test executes a real .cmd shim from a spaced path
  • extension syntax check
  • cold review found no remaining high-confidence issues

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 83dd4f49-a03d-44a0-bdd1-8c4f54da8ec2
@jennyf19
jennyf19 merged commit 6251b8e into main Aug 4, 2026
1 check passed
@jennyf19
jennyf19 deleted the fix/review-feedback branch August 4, 2026 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant