Skip to content

pom update#266

Open
mawinter69 wants to merge 2 commits into
jenkinsci:masterfrom
mawinter69:pom-refresh
Open

pom update#266
mawinter69 wants to merge 2 commits into
jenkinsci:masterfrom
mawinter69:pom-refresh

Conversation

@mawinter69

Copy link
Copy Markdown
  • use latest parent pom
  • replace usages of commons-lang2 with commons-lang3
  • replace deprecated javax.servlet and StaplerRequest
  • ban usage of common-lang-2 classes
  • ban usage of deprecated javax.servlet and Stapler
  • define hpi.strictBundledArtifacts and hpi.bundledArtifacts to prevent accidental packaging of transitive libraries
  • use latest bom
  • remove versions for plugins defined via bom
  • replace gson with api plugin
  • replace json with api plugin
  • replace commons-lang-3 with api plugin
  • exclude dependencies of p4java that are provided via core or plugins
  • remove dependencies to structs and command-launcher, they are not needed
  • commons-exec is only required during tests

These changes reduce the size of the hpi by 50%

Testing done

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests that demonstrate the feature works or the issue is fixed

- use latest parent pom
- replace usages of commons-lang2 with commons-lang3
- replace deprecated javax.servler and StaplerRequest
- ban usage of common-lang-2 classes
- ban usage of deprecated javax.servlet and Stapler
- use latest bom
- remove versions for plugins defined via bom
- replace gson with api plugin
- replace json with api plugin
- replace commons-lang-3 with api plugin
- exclude dependencies of p4java that are provided via core or plugins
- remove dependencies to structs and command-launcher, they are not
  needed
- commons-exec is only required during tests
@mawinter69

Copy link
Copy Markdown
Author

Note that the builds on ci.jenkins.io fail because the Jenkinsfile still tries to build with Java 11. But with 2.479.3 as Jenkins baseline you need at least Java 17.

@mawinter69 mawinter69 marked this pull request as ready for review June 25, 2026 17:46
@skumar7322

Copy link
Copy Markdown
Contributor

Hi @mawinter69
Thanks for creating this PR.

We've recently updated the Jenkins baseline to 2.528. Could you please rebase your changes onto the latest branch and update the PR?

@mawinter69

Copy link
Copy Markdown
Author

Hi @mawinter69 Thanks for creating this PR.

We've recently updated the Jenkins baseline to 2.528. Could you please rebase your changes onto the latest branch and update the PR?

done. Build is green now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants