fix JENKINS-46940 by preventing entries having the same project name from being added more than once - #123
Open
dliakh wants to merge 1 commit into
Open
Conversation
Author
|
Well, need to recheck how that affect [possible] cases of having multiple projects with the same name |
|
Wonder what the checks failure means, and if it happened before this PR. @dliakh I haven't looked at your changes yet, but I'd like to test this. In response to your concerns over side effects, I wonder if it would be possible to add a configuration flag somewhere to make the deduplicating behavior optional. Defaults to off, and turn it on if you want that correction? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JENKINS-46940
In addition to the duplicate protection added earlier (that didn't work for some reason)
also prevent duplicates by checking whether there is an entry having the same project name already.
(Tested on the local Jenkins setup which had an issue with duplicated before the change and doesn't have it after)
Please, can you check whether this technique (preventing duplicates based on the name of the project associated with the entry)
is ok