Skip to content

chore(ci): fail closed without notarization credentials #1415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jdx merged 1 commit into from
Aug 30, 2026
Merged

chore(ci): fail closed without notarization credentials #1415

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,11 @@ on:
CERTIFICATES_P12_PASS:
required: true
APPLE_API_KEY_P8:
required: false
required: true
APPLE_API_KEY_ID:
required: false
required: true
APPLE_API_ISSUER_ID:
required: false
required: true
workflow_dispatch:
inputs:
tag:
Expand Down Expand Up @@ -628,8 +628,8 @@ jobs:
set -euo pipefail

if [ -z "$APPLE_API_KEY_P8" ] || [ -z "$APPLE_API_KEY_ID" ] || [ -z "$APPLE_API_ISSUER_ID" ]; then
echo "::warning title=Not notarized::App Store Connect credentials are unset, so this release ships signed but un-notarized macOS binaries. Gatekeeper will block them for anyone who downloads an archive through a browser."
exit 0
echo "::error title=Notarization credentials missing::App Store Connect credentials are required for macOS releases."
exit 1
fi

# Outside the workspace, so no later step can sweep the key into an
Expand Down
Loading