Repository navigation
Add DSG decoding and labeling support for graph-based optimization - #23
Merged
Merged
Conversation
flatala
commented
Oct 14, 2026
flatala
commented
Contributor
- Introduces DSGGraphDecoder that can decode DSG designs into SBArchOpt’s graph representations.
- Adds node-owned DSG role labels and configurable constant/type labeling selection.
- Introduces DSGSizingEncoder and DesignVariableSizingEncoder for exporting sizing values.
jbussemaker
requested changes
Oct 14, 2026
jbussemaker
left a comment
jbussemaker
left a comment
Owner
There was a problem hiding this comment.
Thanks! One small change ;)
And then I'll wait with running the tests and merging once the new SBArchOpt has been released.
| representations: Dict[Tuple[float, ...], "GraphRepresentation"] = field(default_factory=dict) | ||
|
|
||
|
|
||
| class DSGGraphDecoder: |
Owner
There was a problem hiding this comment.
Shouldn't this inherit from sb_arch_opt.algo.arch_sbo.graph.representation.GraphDecoder? Please make this link explicit.
jbussemaker
self-requested a review
October 17, 2026 14:17
jbussemaker
approved these changes
Oct 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.