Skip to content

Improve ComfyUI output handling for arbitrary workflowsFix/comfyui generic outputs - #159

Open
Shivambakal wants to merge 7 commits into
jbilcke-hf:mainfrom
Shivambakal:fix/comfyui-generic-outputs
Open

Shivambakal wants to merge 7 commits into
jbilcke-hf:mainfrom
Shivambakal:fix/comfyui-generic-outputs

Conversation

@Shivambakal

Copy link
Copy Markdown

Summary

Improves the existing ComfyUI integration by making output discovery and extraction less dependent on a single hard-coded output node or output field.

Changes

  • Makes @clapper/output optional while preserving existing mappings when present.
  • Adds getOutputNodes() to detect multiple terminal/output nodes.
  • Preserves getOutputNode() for compatibility.
  • Recursively extracts filename-bearing assets from nested ComfyUI output structures.
  • Deduplicates discovered output descriptors.
  • Selects the best output asset for the requested Clapper segment category instead of blindly taking the first asset.
  • Adds regression coverage for multiple output nodes, arbitrary nested outputs, duplicate assets, and the local /prompt → /history → /view flow.

Validation

  • ComfyUI tests: 30/30 passing
  • git diff --check: clean
  • Targeted TypeScript check: no ComfyUI-related errors

Fixes #5

@Shivambakal

Copy link
Copy Markdown
Author

Hi @jbilcke-hf — I’ve completed and validated #159. It improves ComfyUI output handling for arbitrary workflows, supports multiple/nested outputs and category-aware asset selection, and adds regression coverage (30/30 ComfyUI tests passing). The PR includes Fixes #5, so merging it into main should automatically close the bounty issue. When you have a chance, could you please review #159 and let me know if any changes are needed? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve ComfyUI integration

2 participants