Skip to content

fix: preserve mtime when setting Path.atime #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
santhreal wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −1
Open

fix: preserve mtime when setting Path.atime #250

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion path/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1047,7 +1047,8 @@ def getatime(self) -> float:
return self.module.getatime(self)

def set_atime(self, value: float | datetime.datetime) -> None:
mtime_ns = self.stat().st_atime_ns
# Preserve mtime; st_atime_ns was a copy-paste bug (clobbered mtime).
mtime_ns = self.stat().st_mtime_ns
self.utime(ns=(_make_timestamp_ns(value), mtime_ns))

@property
Expand Down
9 changes: 9 additions & 0 deletions tests/test_path.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,6 +269,15 @@ def test_utime(self, tmpdir):
new_time = (time.time() - 600,) * 2
assert Path(tmpfile).utime(new_time).stat().st_atime == new_time[0]

def test_set_atime_preserves_mtime(self, tmpdir):
tmpfile = Path(tmpdir) / 'file'
tmpfile.touch()
os.utime(tmpfile, (1000.0, 2000.0))
tmpfile.set_atime(3000.0)
st = tmpfile.stat()
assert st.st_atime == 3000.0
assert st.st_mtime == 2000.0

def test_chmod_str(self, tmpdir):
tmpfile = Path(tmpdir) / 'file'
tmpfile.touch()
Expand Down