Skip to content

fix(mcp): voicebox.speak inherits the voice profile language instead of forcing English #1050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
danansa86 wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −1
Open

fix(mcp): voicebox.speak inherits the voice profile language instead of forcing English #1050

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion backend/mcp_server/tools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,7 @@ async def voicebox_speak(
text=text,
engine=resolved_engine,
language=language,
profile_language=vp.language,
personality=use_persona,
model_size=model_size,
db=db,
Expand Down Expand Up @@ -236,6 +237,7 @@ async def _speak(
engine: str | None,
language: str | None,
personality: bool,
profile_language: str | None = None,
model_size: str | None = None,
db,
) -> dict[str, Any]:
Expand All @@ -246,10 +248,14 @@ async def _speak(
# model_size=None is intentional: generate_speech normalizes it to the
# engine default (see routes/generations.py), so an omitted size behaves
# exactly like the REST /generate endpoint with no model_size in the body.
#
# language precedence: explicit tool arg → the resolved profile's own
# language → "en". Without the profile fallback, a non-English voice
# profile with no explicit language is phonemized as English.
req = models.GenerationRequest(
profile_id=profile_id,
text=text,
language=language or "en",
language=language or profile_language or "en",
engine=engine,
personality=personality,
model_size=model_size,
Expand Down