fix(codex): handle current desktop CDP layout - #2281
Open
yoruuuchan wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
codex asktrack the latest assistant message identity instead of relying on virtualized turn/message countsReproduction
On Windows with OpenCLI 1.8.6 and current Codex Desktop, CDP 9238 exposes both:
app://-/index.html?initialRoute=%2Favatar-overlayapp://-/index.htmlBecause both targets otherwise receive the same effective score,
/jsonorder can select the overlay.codex statusthen reports Connected, whilecodex askcannot find the composer.After selecting the main renderer, prompts can be sent. Current Codex also virtualizes the thread DOM, so the number of
[data-content-search-turn-key]elements may stay unchanged while a new assistant response replaces the visible turn. Assistant messages expose stable per-message identity throughdata-content-search-unit-key/data-response-annotation-target, which this change uses for polling, with the old turn-count behavior kept as a fallback for older builds.Validation
askCommand.func(..., timeout: 60)returnedDIRECT60_OKLocal Vitest startup was blocked by a Windows Rolldown/native-binding lock in the temporary dependency install, so repository CI is the source of truth for the full test matrix.