W2026-31 weko-workflow 単体テスト修正 - #1218
Open
ivis-kondo wants to merge 2 commits into
Open
Conversation
- Added initialization of `actions` variable in `FlowSettingView` to avoid potential reference errors. - Updated `cancel_expired_usage_reports` to handle expired activity IDs more efficiently. - Improved error handling in `next_action`, `get_request_maillist`, and `get_item_application` by directly returning the response payload instead of accessing `.data`. - Enhanced role retrieval in `get_data_init` to exclude superuser roles based on configuration, ensuring better access control.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FlowSettingView内でactions変数の宣言・初期化を追加cancel_expired_usage_reportsを更新next_action、get_request_maillist、およびget_item_applicationにおけるエラー処理を改善し、.dataにアクセスする代わりに、レスポンスのペイロードを直接返すよう変更get_data_initにおけるロールの取得機能を設定に基づいてスーパーユーザーロールを除外するよう修正