Skip to content

Adding JDK 25 build compatibility #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
svanteschubert wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Adding JDK 25 build compatibility #174

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9b22232
Avoid test output files on root level, instead move output to ./target
svanteschubert Feb 17, 2026
9060d4b
Allow builds with java 25 or java 11
svanteschubert Feb 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 20 additions & 3 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,8 @@
<version.assertj>3.27.7</version.assertj>
<version.commons-io>2.21.0</version.commons-io>
<version.commons-lang>3.20.0</version.commons-lang>
<version.jacoco>0.8.13</version.jacoco>
<!-- JaCoCo 0.8.14+ required for Java 25 (class file major version 69) -->
<version.jacoco>0.8.14</version.jacoco>
<version.jaxb-api>4.0.4</version.jaxb-api>
<version.jaxb-impl>4.0.6</version.jaxb-impl>
<version.lombok>1.18.42</version.lombok>
Expand All @@ -52,6 +53,8 @@
<version.saxon-he>12.9</version.saxon-he>
<version.slf4j>2.0.17</version.slf4j>
<version.jaxb-maven-plugin>4.0.11</version.jaxb-maven-plugin>
<!-- Set to true to skip formatter:validate (e.g. -DskipFormatterValidation=true) when formatting is not yet applied or in CI -->
<skipFormatterValidation>false</skipFormatterValidation>
</properties>

<repositories>
Expand Down Expand Up @@ -110,6 +113,7 @@
<optional>true</optional>
</dependency>

<!-- 3.18.0+ fixes CVE-2025-48924 (uncontrolled recursion in ClassUtils.getClass on long inputs); 3.10 had no remediation in older scanners -->
<dependency>
<groupId>org.apache.commons</groupId>
<artifactId>commons-lang3</artifactId>
Expand Down Expand Up @@ -138,6 +142,7 @@
<version>4.13.2</version>
<scope>test</scope>
</dependency>
<!-- 2.17.0+ fixes CVE-2024-47554 (XML DoS in XmlStreamReader) and directory traversal in FileNameUtils.normalize; 2.6 was vulnerable -->
<dependency>
<groupId>commons-io</groupId>
<artifactId>commons-io</artifactId>
Expand Down Expand Up @@ -296,6 +301,14 @@
See: https://inside.java/2024/06/18/quality-heads-up/
-->
<proc>full</proc>
<!-- Explicit processor path ensures Lombok runs on JDK 25; without it the compiler may not invoke the processor and getters/setters/log are missing -->
<annotationProcessorPaths>
<path>
<groupId>org.projectlombok</groupId>
<artifactId>lombok</artifactId>
<version>${version.lombok}</version>
</path>
</annotationProcessorPaths>
</configuration>
</plugin>

Expand Down Expand Up @@ -383,7 +396,7 @@
</executions>
</plugin>

<!-- Generate model classes -->
<!-- Generate model classes from XSD. Plugin default pulls JAXB 2.3.0 which uses sun.misc.Unsafe.defineClass, removed in Java 21+; overrides below fix generate goal on modern JDKs -->
<plugin>
<groupId>org.jvnet.jaxb</groupId>
<artifactId>jaxb-maven-plugin</artifactId>
Expand Down Expand Up @@ -413,7 +426,7 @@
</configuration>
</plugin>

<!-- Integrate code coverage -->
<!-- Code coverage. Version must be 0.8.14+ on Java 25 (see version.jacoco property comment). -->
<plugin>
<groupId>org.jacoco</groupId>
<artifactId>jacoco-maven-plugin</artifactId>
Expand Down Expand Up @@ -618,6 +631,10 @@
<goals>
<goal>validate</goal>
</goals>
<configuration>
<!-- Skip when skipFormatterValidation=true (see property); avoids build failure if sources are not yet formatted -->
<skip>${skipFormatterValidation}</skip>
</configuration>
</execution>
</executions>
<configuration>
Expand Down
7 changes: 6 additions & 1 deletion src/main/java/de/kosit/validationtool/impl/input/SourceInput.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,12 @@ private boolean isConsumed() {
return (ss.getInputStream() != null && ss.getInputStream().available() == 0)
|| (ss.getReader() != null && !ss.getReader().ready());
} catch (final IOException e) {
log.error("Error checking consumed state", e);
// Stream/reader closed is an expected outcome when consumed; avoid ERROR log
if (e.getMessage() == null || !e.getMessage().toLowerCase().contains("closed")) {
log.error("Error checking consumed state", e);
} else {
log.debug("Stream/reader closed when checking consumed state", e);
}
return true;
}
}
Expand Down
9 changes: 5 additions & 4 deletions src/test/java/de/kosit/validationtool/cmd/CommandlineApplicationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,8 +150,9 @@ public void testValidMinimalConfigurationXSLTRuntimeError() {

@Test
public void testValidNamingConfiguration() {
final String[] args = { "-s", Paths.get(Simple.SCENARIOS).toString(), "-r", Paths.get(Simple.REPOSITORY_URI).toString(),
Paths.get(Simple.SIMPLE_VALID).toString(), "--report-prefix", "somePrefix", "--report-postfix", "somePostfix" };
final String[] args = { "-s", Paths.get(Simple.SCENARIOS).toString(), "-o", this.output.toString(), "-r",
Paths.get(Simple.REPOSITORY_URI).toString(), Paths.get(Simple.SIMPLE_VALID).toString(), "--report-prefix", "somePrefix",
"--report-postfix", "somePostfix" };
CommandLineApplication.mainProgram(args);
assertThat(CommandLine.getErrorOutput()).contains(RESULT_OUTPUT);
assertThat(CommandLine.getErrorOutput()).contains("somePrefix-simple-somePostfix");
Expand Down Expand Up @@ -249,8 +250,8 @@ public void testReadFromPipe() throws IOException {

@Test
public void testAndre() {
final String[] args = { "-s", Paths.get(Simple.SCENARIOS).toString(), "-r", Paths.get(Simple.REPOSITORY_URI).toString(),
Paths.get(Simple.SIMPLE_VALID).toString(), "--report-prefix", "andre1" };
final String[] args = { "-s", Paths.get(Simple.SCENARIOS).toString(), "-o", this.output.toString(), "-r",
Paths.get(Simple.REPOSITORY_URI).toString(), Paths.get(Simple.SIMPLE_VALID).toString(), "--report-prefix", "andre1" };
CommandLineApplication.mainProgram(args);
assertThat(CommandLine.getErrorOutput()).contains(RESULT_OUTPUT);
}
Expand Down