Repository navigation
fix: resolve native DOCX parsing failures with numbering overrides - #14
Merged
Merged
Conversation
- Register the CTNumLvlImpl constructor for Windows, Linux, and macOS - Add regression tests for DOCX numbering overrides - Verify all four previously failing DOCX files on Windows - Pass 13 numbering tests and 7 Unicode regression tests
Author
|
Hi! Just a friendly reminder about this PR. When you have a chance, could you please take a look? I'd be happy to make any changes if needed. Thanks for your time! |
Member
|
Thanks a lot for this, and sorry for the wait! The fix will be in the next release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix native DOCX parsing failures with numbering overrides
Summary
DOCX files containing
w:lvlOverridefailed in native builds because theCTNumLvlImpl(SchemaType)constructor was missing from reachability metadata.Changes
Verification
Reproduction files
Plymouth City Council DOCX documents: Scenario 5 (SEN), 6 (Neglect), 7 (Social Networking), and 8 (Contact Issues).
public_plymouth_gov_uk_Scenario-7-Social-Networking_b7ef6cdedd.docx
public_plymouth_gov_uk_Scenario-8-Contact-Issues_961936b2ad.docx
public_plymouth_gov_uk_Scenario-5-SEN_bf13851adc.docx
public_plymouth_gov_uk_Scenario-6-Neglect_34ab38b2e0.docx