Repository navigation
Add scripts for OpenAPI generation and post-generation and more convenience - #100
Merged
Merged
Conversation
splch
reviewed
Sep 1, 2026
2 of 3 tasks
hodgestar-ionq
previously approved these changes
Sep 1, 2026
hodgestar-ionq
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me. Thank you for adding the Makefile. I left a couple of questions.
Collaborator
|
Heads-up: #101 added spec-sync.yml, which carries the same regeneration invocation as generated.yml. If this PR changes how regeneration is invoked, please update spec-sync.yml in the same change so the weekly bot regen and the staleness check stay identical. |
Collaborator
|
zizmor noo! |
splch
approved these changes
Oct 8, 2026
hodgestar-ionq
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/regenerate_models.pyas the OS-independent way to regenerate the clientpost_hooksinopenapi-python-client-config.yamlwithscripts/post_generate.py(same behavior: SPDX/@generatedheaders,tokenhidden fromrepr) — the perl quoting was Unix-only and broke generation on Windows.Makefilewith shorthand targets (regen,sync-spec,check-generated,lint,test, ...) that wrap the script and the existinguv runcommands.generated.ymlnow runs the script on a Linux/macOS/Windows matrix (staleness gate on Linux), so the regeneration command is defined in one place and exercised on all supported platforms.ci.ymltest matrix gains macOS and Windows entries (Python 3.14,--no-cov).CONTRIBUTING.mdto document the script as the regeneration workflow.Test plan
uv run --group regen python scripts/regenerate_models.pyreproduces the committed generated code with zero diff (i.e. the Python post-hooks are byte-identical to the perl ones).ruff check,ruff format --check, andty checkclean.generated.ymlstaleness jobs pass on ubuntu, macos, and windows on this PR.Note: Used the help of Claude Code for this PR. 🤖