Fix: Anima regional prompting should mirror width/height calculation for correct mask size#9356
Open
FrankBro wants to merge 2 commits into
Open
Conversation
Extract the image token grid computation into AnimaDenoiseInvocation._compute_img_token_grid so it can be unit tested, and add TestComputeImgTokenGrid. The key test cross-checks the grid against the transformer's real MiniTrainDIT._pad_to_patch_size so the mask sizing and the transformer's patchified grid cannot silently drift, plus a regression case for the 1080x1920 (8160 vs 8040) mask shape mismatch. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When using regional prompting with the Anima models, I would receive this error:
An inverted ceil vs floor type division caused an off by 1 error.
QA Instructions
Claude used this script to confirm the math was wrong, based on my resolution (1080x1920) and the error message.
I build my version of the code locally and can confirm the popup error does not appear anymore.
Additionally, I extracted the calculation into its own static function before adding a unit test to check for this regression.
Checklist
What's Newcopy (if doing a release after this PR)