Skip to content

feat: add s3 bucket creation for rustfs - #436

Open
tmorrell wants to merge 1 commit into
inveniosoftware:masterfrom
caltechlibrary:rustfs
Open

tmorrell wants to merge 1 commit into
inveniosoftware:masterfrom
caltechlibrary:rustfs

Conversation

@tmorrell

Copy link
Copy Markdown
Contributor

❤️ Thank you for your contribution!

Description

Requires inveniosoftware/invenio-s3#55. RustFS doesn't create a bucket automatically like minio did.

Claude assisted with this code.

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Frontend

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.

Comment thread invenio_cli/commands/services.py

def test_setup_local_storage_skips_bucket_creation(mock_cli_config):
assert "Creating default S3 bucket..." not in _setup_messages(mock_cli_config)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we assert the “already exists” case here?
Checking only the exit code doesn’t verify that the FileExistsError branch was exercised.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants