Skip to content

config: add React 18 ESLint configuration - #20

Merged
zzacharo merged 3 commits into
inveniosoftware:masterfrom
oarepo:mirekys/eslint-phase0-react18
Apr 30, 2026
Merged

config: add React 18 ESLint configuration#20
zzacharo merged 3 commits into
inveniosoftware:masterfrom
oarepo:mirekys/eslint-phase0-react18

Conversation

@mirekys

@mirekys mirekys commented Apr 10, 2026

Copy link
Copy Markdown
Contributor

❤️ Thank you for your contribution!

Description

Implements Phase 0 of the React 18 migration RFC (inveniosoftware/rfcs#112).

Adds new @inveniosoftware/invenio/react18 subpath export with React 18 specific ESLint rules. Disables jsx-uses-react/react-in-jsx-scope for automatic JSX transform, restricts enzyme-adapter-react-16 and react-dom/test-utils imports, and enables explicit React Hooks rules.

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Frontend

Reminder

By using GitHub, you have already agreed to the GitHub's Terms of Service including that:

  1. You license your contribution under the same terms as the current repository's license.
  2. You agree that you have the right to license your contribution under the current repository's license.

@mirekys mirekys added this to v14 Apr 13, 2026
@mirekys
mirekys force-pushed the mirekys/eslint-phase0-react18 branch 5 times, most recently from fa9ee5a to 4fd117d Compare April 22, 2026 18:23
@mirekys
mirekys force-pushed the mirekys/eslint-phase0-react18 branch 2 times, most recently from e0a9bff to 7849370 Compare April 27, 2026 11:37

@OliverGeneser OliverGeneser left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zzacharo zzacharo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a minor comment out of curiosity

Comment thread react18.js Outdated
@mirekys
mirekys force-pushed the mirekys/eslint-phase0-react18 branch from 712b516 to eef1a34 Compare April 30, 2026 08:02
mirekys added 2 commits April 30, 2026 10:24
* Adds new @inveniosoftware/invenio/react18 subpath export

* Disables react-in-jsx-scope and jsx-uses-react rules for React 17+ automatic JSX transform

* Adds no-restricted-imports for enzyme-adapter-react-16 migration

* Adds no-restricted-imports for react-dom/test-utils to guide developers toward React 18 createRoot API

* Explicitly configures react-hooks rules for React 18 compatibility
@mirekys
mirekys force-pushed the mirekys/eslint-phase0-react18 branch from eef1a34 to fd6aae9 Compare April 30, 2026 08:40
@mirekys
mirekys force-pushed the mirekys/eslint-phase0-react18 branch from 5bba84e to a609a75 Compare April 30, 2026 12:13
@zzacharo
zzacharo merged commit ccda667 into inveniosoftware:master Apr 30, 2026
@github-project-automation github-project-automation Bot moved this to To release 🤖 in v14 Apr 30, 2026
@mirekys mirekys moved this from To release 🤖 to Released ✔ in v14 Apr 30, 2026
@fenekku fenekku moved this from Released ✔ to Done ✔️ in v14 Jul 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done ✔️

Development

Successfully merging this pull request may close these issues.

4 participants