Skip to content

fix: guard release tag against workspace version mismatch #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Atishyy27 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: guard release tag against workspace version mismatch #60

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions release.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,17 @@ fi
SCRIPT_DIR="$(cd "$(dirname "$0")" && pwd)"
cd "$SCRIPT_DIR"

# Guard: the tag must match the workspace version, or the binaries built
# below will report a version (via clap's `version` from CARGO_PKG_VERSION)
# that disagrees with the release tag they're uploaded under.
CARGO_VERSION="$(grep -m1 '^version = ' Cargo.toml | sed -E 's/version = "(.*)"/\1/')"
TAG_VERSION="${VERSION#v}"
if [ "$TAG_VERSION" != "$CARGO_VERSION" ]; then
echo "Error: release tag ${VERSION} does not match [workspace.package].version ${CARGO_VERSION} in Cargo.toml."
echo "Bump the workspace version to ${TAG_VERSION}, or run: $0 v${CARGO_VERSION}"
exit 1
fi

# Detect current platform
OS="$(uname -s)"

Expand Down