Repository navigation
[raft] Keep URL of removed nodes and reject duplicates - #1895
Merged
Merged
Conversation
MariemBaccari
force-pushed
the
record_names
branch
from
November 3, 2026 08:16
f3039d4 to
b6483f6
Compare
Contributor
|
IMO the name 'name' is confusing: I'd expect this to be cosmetic. But here this is still a identifier, just of a different kind. In general I think we should have a clear terminology that is used across the interfaces (like the CLI in naming and description) and the doc.
|
This was referenced Nov 3, 2026
MariemBaccari
force-pushed
the
record_names
branch
from
November 3, 2026 14:32
b6483f6 to
11fc3cf
Compare
MariemBaccari
changed the title
MariemBaccari
force-pushed
the
record_names
branch
from
November 3, 2026 14:36
11fc3cf to
4ab75af
Compare
Contributor
Author
|
@mickmis As discussed offline, |
MariemBaccari
force-pushed
the
record_names
branch
2 times, most recently
from
November 4, 2026 08:27
f7f7f68 to
bd86d13
Compare
MariemBaccari
force-pushed
the
record_names
branch
from
November 4, 2026 14:21
bd86d13 to
442f45a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR partially addresses #1719 and #1802. Nodes are now identified by their URL. Adding a node with an already used URL is rejected. Removed nodes keep their URLs.
This PR aligns
consensuswith the admin API's expectations.